MD Settings: preload Roboto bold to reduce flicker

MD Settings: preload Roboto bold to reduce flicker

R=dpapad@chromium.org
BUG=651730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/90bc6bfd63b17209926b0028f34ef8cd3e36b620
Cr-Commit-Position: refs/heads/master@{#422514}

[Dan Beam, 2016-09-30 22:19:58]

Description was changed from

==========
MD Settings: preload Roboto bold to reduce flicker

R=dpapad@chromium.org
BUG=651730
==========

to

==========
MD Settings: preload Roboto bold to reduce flicker

R=dpapad@chromium.org
BUG=651730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-01 02:12:57]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 02:13:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-10-01 02:14:51]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2016-10-01 02:14:57]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-01 02:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 03:09:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 03:09:04]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-03 17:32:00]

LGTM

https://codereview.chromium.org/2385873002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2385873002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.js:110:
document.fonts.load('bold 12px Roboto');
Perhaps add a short comment explaining why this is necessary. I don't think it
will be obvious to future readers.

[Dan Beam, 2016-10-03 19:26:48]

https://codereview.chromium.org/2385873002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.js (right):

https://codereview.chromium.org/2385873002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.js:110:
document.fonts.load('bold 12px Roboto');
On 2016/10/03 17:31:59, dpapad wrote:
> Perhaps add a short comment explaining why this is necessary. I don't think it
> will be obvious to future readers.

Done.

[Dan Beam, 2016-10-03 19:26:53]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-10-03 19:26:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2385873002/#ps40001
(title: "comment for dpapad@")

[commit-bot: I haz the power, 2016-10-03 19:27:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:28:03]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-03 20:31:16]

Description was changed from

==========
MD Settings: preload Roboto bold to reduce flicker

R=dpapad@chromium.org
BUG=651730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: preload Roboto bold to reduce flicker

R=dpapad@chromium.org
BUG=651730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/90bc6bfd63b17209926b0028f34ef8cd3e36b620
Cr-Commit-Position: refs/heads/master@{#422514}
==========

[commit-bot: I haz the power, 2016-10-03 20:31:17]

Patchset 2 (id:??) landed as
https://crrev.com/90bc6bfd63b17209926b0028f34ef8cd3e36b620
Cr-Commit-Position: refs/heads/master@{#422514}

[michaelpg, 2016-10-04 04:37:49]

did we give up on `font-display`?

On Mon, Oct 3, 2016, 1:31 PM commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

Patchset 2 (id:??) landed as
https://crrev.com/90bc6bfd63b17209926b0028f34ef8cd3e36b620
Cr-Commit-Position: refs/heads/master@{#422514}

https://codereview.chromium.org/2385873002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2016-10-04 04:45:21]

On 2016/10/04 04:37:49, michaelpg wrote:
> did we give up on `font-display`?

I'm not sure but we had a big talk about whether we wanted to lazy/remotely load
Roboto from the web fonts API.

It'd save a bit of space for the installer, but it'd be slightly more
code/access.

Just don't think it was a huge priority for anybody yet, and font-display wasn't
quite tune-able to our liking.

[michaelpg, 2016-10-04 05:29:23]

On 2016/10/04 04:45:21, Dan Beam wrote:
> On 2016/10/04 04:37:49, michaelpg wrote:
> > did we give up on `font-display`?
> 
> I'm not sure but we had a big talk about whether we wanted to lazy/remotely
load
> Roboto from the web fonts API.
> 
> It'd save a bit of space for the installer, but it'd be slightly more
> code/access.
> 
> Just don't think it was a huge priority for anybody yet, and font-display
wasn't
> quite tune-able to our liking.

ah ok, thanks for the context!