Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2385853002: [Merge to M54] Revert "Revert "[ARC] Add "(beta)" string to Play Store."" (Closed)

Created:
4 years, 2 months ago by xdai1
Modified:
4 years, 2 months ago
Reviewers:
xiyuan, Dan Beam
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge to M54] Revert "Revert "[ARC] Add "(beta)" string to Play Store."" This reverts commit d972e190a99e96c243d4d8ba421fb61a5c26d4ec. See https://codereview.chromium.org/2329063002. The "(beta)" string also needs to be merged to M54. This CL will be reverted later again once it has been merged to M54. Note the "(beta)" string also needs to go to M55 and later, but it will be done in a seperate CL since it's not necessarily to reuse the existing string and can be done in a cleaner way. BUG=644576 TBR=xiyuan@chromium.org, dbeam@chromium.org Review URL: https://codereview.chromium.org/2380383002 . Cr-Commit-Position: refs/heads/master@{#422168} (cherry picked from commit bb3a0d028a5fc5e1c92740a5b2ea910d35f76e29) Committed: https://chromium.googlesource.com/chromium/src/+/d6167a9a07466db1f025513f568643779b2d831d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
xdai1
4 years, 2 months ago (2016-09-30 20:21:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6167a9a07466db1f025513f568643779b2d831d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698