Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2385843002: Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK (Closed)

Created:
4 years, 2 months ago by jaydasika
Modified:
4 years, 2 months ago
Reviewers:
dominickn, Xi Han, pkotwicz
CC:
chromium-reviews, dominickn+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages (patchset #2 id:40001 of https://codereview.chromium.org/2362813003/ ) Reason for revert: "CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky on android_n5x_swarming_rel Original issue's description: > Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages > > This CL: > - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo > is ignored for WebAPK compatible pages. > - Adds tests checking that WebApplicationInfo is ignored > > BUG=638468 > > Committed: https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9 > Cr-Commit-Position: refs/heads/master@{#421531} TBR=hanxi@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=638468, 651289 Committed: https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8 Cr-Commit-Position: refs/heads/master@{#422170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -64 lines) Patch
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc View 3 chunks +1 line, -59 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jaydasika
Created Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages
4 years, 2 months ago (2016-09-30 18:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385843002/1
4 years, 2 months ago (2016-09-30 18:32:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 19:08:59 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 19:12:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8
Cr-Commit-Position: refs/heads/master@{#422170}

Powered by Google App Engine
This is Rietveld 408576698