Chromium Code Reviews
DescriptionRevert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages (patchset #2 id:40001 of https://codereview.chromium.org/2362813003/ )
Reason for revert:
"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky on android_n5x_swarming_rel
Original issue's description:
> Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages
>
> This CL:
> - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
> is ignored for WebAPK compatible pages.
> - Adds tests checking that WebApplicationInfo is ignored
>
> BUG=638468
>
> Committed: https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9
> Cr-Commit-Position: refs/heads/master@{#421531}
TBR=hanxi@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=638468, 651289
Committed: https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8
Cr-Commit-Position: refs/heads/master@{#422170}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
||||||||||||||||||||||||||||