Image Capture Android: wire color temperature set/get

Image Capture Android: wire color temperature set/get

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.

Committed: https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b
Cr-Commit-Position: refs/heads/master@{#422832}

[mcasas, 2016-10-03 04:53:18]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-10-03 07:28:25]

Description was changed from

==========
Image Capture Android: wire color temperature set/get

wip

BUG=650675
==========

to

==========
Image Capture Android: wire color temperature set/get

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.
==========

[mcasas, 2016-10-03 07:29:05]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2016-10-03 07:29:06]

reillyg@ PTAL.

[Reilly Grant (use Gerrit), 2016-10-03 07:38:15]

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:428:
if (index > 0)
builder.setCurrentColorTemperature(COLOR_TEMPERATURES_MAP.keyAt(index));
>= 0?

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:430:
builder.setCurrentColorTemperature(0);
Since we don't call setCurrentColorTemperature() above if index < 0 isn't this
line unnecessary?

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:774:
if (index > 0) {
>= 0?

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:777:
builder.setCurrentColorTemperature(0);
Is this line necessary?

[mcasas, 2016-10-03 16:08:39]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-10-03 16:17:19]

ptal

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:428:
if (index > 0)
builder.setCurrentColorTemperature(COLOR_TEMPERATURES_MAP.keyAt(index));
On 2016/10/03 07:38:15, Reilly Grant wrote:
> >= 0?

Done.

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:430:
builder.setCurrentColorTemperature(0);
On 2016/10/03 07:38:15, Reilly Grant wrote:
> Since we don't call setCurrentColorTemperature() above if index < 0 isn't this
> line unnecessary?

Done.

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:774:
if (index > 0) {
On 2016/10/03 07:38:15, Reilly Grant wrote:
> >= 0?

Done.

https://codereview.chromium.org/2385833002/diff/40001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:777:
builder.setCurrentColorTemperature(0);
On 2016/10/03 07:38:15, Reilly Grant wrote:
> Is this line necessary?

Done.

[Reilly Grant (use Gerrit), 2016-10-04 07:16:54]

lgtm

[mcasas, 2016-10-04 16:04:52]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-10-04 16:05:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:07:14]

Description was changed from

==========
Image Capture Android: wire color temperature set/get

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.
==========

to

==========
Image Capture Android: wire color temperature set/get

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.
==========

[commit-bot: I haz the power, 2016-10-04 17:07:18]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-04 17:08:29]

Description was changed from

==========
Image Capture Android: wire color temperature set/get

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.
==========

to

==========
Image Capture Android: wire color temperature set/get

This CL adds getter/setter for colour temperature for
Android implementation.  JS API uses Kelvin grades,
whereas the platform uses names, so a mapping of
sorts is introduced.

BUG=650675
TEST= by hand using the JS ImageCapture API.

Committed: https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b
Cr-Commit-Position: refs/heads/master@{#422832}
==========

[commit-bot: I haz the power, 2016-10-04 17:08:30]

Patchset 2 (id:??) landed as
https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b
Cr-Commit-Position: refs/heads/master@{#422832}