Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2385823002:
Pass preallocation hints to SkRWBuffer (Closed)
|
Created:
4 years, 2 months ago by f(malita) Modified:
4 years, 2 months ago CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPass preallocation hints to SkRWBuffer
Compute how much more data we're going to append, and pass that info
to SkRWBuffer::append() to minimize the number of internal allocations.
BUG=651698
R=scroggo@chromium.org,reed@google.com
Committed: https://crrev.com/502fceb9cf8e8c70ba2f90c5dac08cc62ef385d3
Cr-Commit-Position: refs/heads/master@{#422333}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 20 (11 generated)
Depends on https://codereview.chromium.org/2385803002/
lgtm
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:
While running git apply --index -3 -p1;
error: patch failed:
third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:163
Falling back to three-way merge...
Applied patch to
'third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp' with
conflicts.
U third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
Patch:
third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
diff --git
a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
index
62529643b6be1c9b5f514da7ddc461abe057fa29..bc4f199af975530c5303d2ed052cc273a0dc9244
100644
--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
@@ -163,7 +163,9 @@ void
DeferredImageDecoder::setDataInternal(PassRefPtr<SharedBuffer> passData, bo
const char* segment = 0;
for (size_t length = data->getSomeData(segment, m_rwBuffer->size());
length; length = data->getSomeData(segment, m_rwBuffer->size())) {
- m_rwBuffer->append(segment, length);
+ DCHECK_GE(data->size(), m_rwBuffer->size() + length);
+ const size_t remaining = data->size() - m_rwBuffer->size() -
length;
+ m_rwBuffer->append(segment, length, remaining);
}
}
}
The CQ bit was checked by fmalita@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@chromium.org Link to the patchset: https://codereview.chromium.org/2385823002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Pass preallocation hints to SkRWBuffer Compute how much more data we're going to append, and pass that info to SkRWBuffer::append() to minimize the number of internal allocations. BUG=651698 R=scroggo@chromium.org,reed@google.com ========== to ========== Pass preallocation hints to SkRWBuffer Compute how much more data we're going to append, and pass that info to SkRWBuffer::append() to minimize the number of internal allocations. BUG=651698 R=scroggo@chromium.org,reed@google.com Committed: https://crrev.com/502fceb9cf8e8c70ba2f90c5dac08cc62ef385d3 Cr-Commit-Position: refs/heads/master@{#422333} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/502fceb9cf8e8c70ba2f90c5dac08cc62ef385d3 Cr-Commit-Position: refs/heads/master@{#422333} |
