Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 23858006: Revert 222650 "Copy asan_rtl.* and agent_logger.exe to the syzyg..." (Closed)

Created:
7 years, 3 months ago by Sigurður Ásgeirsson
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222650 "Copy asan_rtl.* and agent_logger.exe to the syzyg..." The change breaks the official ASAN Canaries. BUG=290090 NOTRY=true > Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds. > > Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja: > > - ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway > - ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway > > The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts. > > I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it. > > I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target. > > R=chrisha@chromium.org > BUG= > > Review URL: https://chromiumcodereview.appspot.com/23460023 TBR=sebmarchand@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222778

Patch Set 1 #

Patch Set 2 : Patch from Git, as drover fails committing for me. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -35 lines) Patch
M chrome/chrome_syzygy.gyp View 1 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/chrome_syzygy.gypi View 1 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/tools/build/win/syzygy_instrument.py View 1 5 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sigurður Ásgeirsson
7 years, 3 months ago (2013-09-12 13:13:37 UTC) #1
Sébastien Marchand
lgtm
7 years, 3 months ago (2013-09-12 13:15:46 UTC) #2
Sigurður Ásgeirsson
7 years, 3 months ago (2013-09-12 13:30:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r222778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698