DescriptionRevert 222650 "Copy asan_rtl.* and agent_logger.exe to the syzyg..."
The change breaks the official ASAN Canaries.
BUG=290090
NOTRY=true
> Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds.
>
> Currently the syzygy_optimize script was taking care of copying asan_rtl.[dll|pdb] to the syzygy directory, this was causing 2 warnings when building a SyzyASan splitted build with ninja:
>
> - ninja: warning: multiple rules generate syzygy\asan_rtl.dll. builds involving this target will not be correct; continuing anyway
> - ninja: warning: multiple rules generate syzygy\asan_rtl.dll.pdb. builds involving this target will not be correct; continuing anyway
>
> The multiple rules come from the fact that both syzygy\chrome.dll and syzygy\chrome_child.dll were trying to generate those artifacts.
>
> I've also added agent_logger.exe to the syzygy directory, with this it'll be easier for the person grabing a SyzyASan build from the LKGR builder to use it.
>
> I've also removed all the "--agent-dll" logic from syzygy_instrument.py as it was only copying the asan binaries to the syzygy directory, it's now done directly in the 'copy_syzyasan_binaries' gyp target.
>
> R=chrisha@chromium.org
> BUG=
>
> Review URL: https://chromiumcodereview.appspot.com/23460023
TBR=sebmarchand@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222778
Patch Set 1 #Patch Set 2 : Patch from Git, as drover fails committing for me. #
Messages
Total messages: 3 (0 generated)
|