content/renderer/render_frame_impl.h - Issue 2385773003: Add UMA to measure feasibility of making unique names immutable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2385773003: Add UMA to measure feasibility of making unique names immutable (Closed)

Patch Set: comments + uma xml Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index b5904b226ef97ff5fef68b2a10a4ea16a8f1bea8..3e0094dcba77901f0074d90c492a41c5b7a77352 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -1293,6 +1293,10 @@ class CONTENT_EXPORT RenderFrameImpl

std::unique_ptr<AssociatedInterfaceProviderImpl>

remote_associated_interfaces_;

+ // TODO(dcheng): Remove these members.

+ bool committed_first_load_ = false;

+ bool name_changed_before_first_commit_ = false;

base::WeakPtrFactory<RenderFrameImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);