Issue 2385753002: [Merge-M54] Fix possible overlapping icons in shelf on sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2385753002: [Merge-M54] Fix possible overlapping icons in shelf on sync. (Closed)

Created:
4 years, 2 months ago by khmel

Modified:
4 years, 2 months ago

Reviewers:
reviewer

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge-M54] Fix possible overlapping icons in shelf on sync. This fixes overlapping icons in shelf on sync, refactored pin applying functionality. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true BUG=649717 BUG=b/31632644 TEST=unit_tests TEST=Manually on device, no glitches with shelf icon were found. Review-Url: https://codereview.chromium.org/2364983002 Cr-Commit-Position: refs/heads/master@{#421613}

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -102 lines)			Patch
M	ash/common/shelf/shelf_view.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc	View	3 chunks	+58 lines, -98 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_item_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385753002/1

4 years, 2 months ago (2016-09-30 15:29:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages