Use the generic heap shim with SyzyASAN.

Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/4d1f56888c68dcda9aa4ad7045b71a6c0eb5969d
Cr-Commit-Position: refs/heads/master@{#422138}

[Sigurður Ásgeirsson, 2016-09-30 14:27:36]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 14:27:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2016-09-30 14:28:15]

Hey Chris,

I'm still testing this, but as we discussed, I don't see why it wouldn't be a
good idea.

Siggi

[Sigurður Ásgeirsson, 2016-09-30 14:31:54]

Description was changed from

==========
Use the generic heap shim with SyzyASAN.

BUG=627455
R=chrisha@chromium.org
==========

to

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
==========

[commit-bot: I haz the power, 2016-09-30 15:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:34:59]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2016-09-30 16:00:53]

siggi@chromium.org changed reviewers:
+ brettw@chromium.org

[Sigurður Ásgeirsson, 2016-09-30 16:00:53]

OK, this works just fine for me. Suggest we run it over the weekend and look at
renderer OOM on Monday. This ought to improve the OOM rates.

Brett for OWNERS, pretty please?

[chrisha, 2016-09-30 17:07:10]

lgtm!

[Sigurður Ásgeirsson, 2016-09-30 17:09:09]

Description was changed from

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
==========

to

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
TBR=brettw@chromium.org
==========

[Sigurður Ásgeirsson, 2016-09-30 17:10:03]

On 2016/09/30 17:07:10, chrisha (slow) wrote:
> lgtm!

Thanks, I'm going to TBR brettw so we can get this into the SyzyASAN.FYI builder
before EOD. I'll sign up for reverting this tomorrow morning if we bork the
SyzyASAN canary.

[Sigurður Ásgeirsson, 2016-09-30 17:10:08]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2016-09-30 17:10:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 17:16:52]

Description was changed from

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
TBR=brettw@chromium.org
==========

to

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-09-30 17:16:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-30 17:25:54]

Description was changed from

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
TBR=brettw@chromium.org
==========

to

==========
Use the generic heap shim with SyzyASAN.

This allows the generic shim to supply malloc_unchecked, which in turn fixes
base::UncheckedMalloc so it returns nullptr instead of barfing on OOM.

BUG=627455
R=chrisha@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/4d1f56888c68dcda9aa4ad7045b71a6c0eb5969d
Cr-Commit-Position: refs/heads/master@{#422138}
==========

[commit-bot: I haz the power, 2016-09-30 17:25:55]

Patchset 1 (id:??) landed as
https://crrev.com/4d1f56888c68dcda9aa4ad7045b71a6c0eb5969d
Cr-Commit-Position: refs/heads/master@{#422138}

[brettw, 2016-09-30 20:53:25]

lgtm

[brettw, 2016-09-30 20:53:25]

lgtm

lgtm