Issue 23857009: Handlify JSObject::AddProperty helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23857009: Handlify JSObject::AddProperty helpers. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify JSObject::AddProperty helpers. R=verwaest@chromium.org

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -139 lines)			Patch
	M	src/objects.h	View		6 chunks	+28 lines, -37 lines	0 comments	Download
	M	src/objects.cc	View		5 chunks	+108 lines, -102 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

https://codereview.chromium.org/23857009/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23857009/diff/1/src/objects.cc#newcode1927 src/objects.cc:1927: void JSObject::AddFastProperty(Handle<JSObject> object, Could we rename this to either ...

7 years, 3 months ago (2013-09-11 13:11:32 UTC) #2

Michael Starzinger

7 years, 3 months ago (2013-09-17 11:04:17 UTC) #3

Superseded by https://codereview.chromium.org/23601031/. Closing.

Expand Messages | Collapse Messages