[Android] Log instr test start & end.

[Android] Log instr test start & end.

BUG=651984
Committed: https://crrev.com/ddf32ac6c05d9c688aace9f9f7a94b912b29af6a
Cr-Commit-Position: refs/heads/master@{#423012}

[jbudorick, 2016-09-30 23:58:23]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org

[jbudorick, 2016-09-30 23:58:24]

I'm going to send this through the trybots a few times to see its effect on
runtime.

[mikecase (-- gone --), 2016-10-01 01:04:38]

https://codereview.chromium.org/2385673005/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2385673005/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:260:
self._test_instance.test_package.split('.')[-1],
is this tag just the word "tests"?

Like "org.chromium.chrome.tests".split('.')[-1]

https://codereview.chromium.org/2385673005/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:262:
check_return=True)
So there will be two logs indicating the start of the test.

I tests: START testA                        // Logged here
I TestRunner: started: testA(a.b.c.MyTest)  // Logged by
InstrumentationTestRunner

Should we make it clearer that one of these logs come from host side and just
tag with "test_runner.py"

I test_runner.py: START testA               // Logged here
I TestRunner: started: testA(a.b.c.MyTest)  // Logged by
InstrumentationTestRunner

[jbudorick, 2016-10-04 21:54:25]

https://codereview.chromium.org/2385673005/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2385673005/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:260:
self._test_instance.test_package.split('.')[-1],
On 2016/10/01 01:04:38, mikecase wrote:
> is this tag just the word "tests"?
> 
> Like "org.chromium.chrome.tests".split('.')[-1]

Clearly wasn't thinking this through all the way. Changing this, see below.

https://codereview.chromium.org/2385673005/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:262:
check_return=True)
On 2016/10/01 01:04:38, mikecase wrote:
> So there will be two logs indicating the start of the test.
> 
> I tests: START testA                        // Logged here
> I TestRunner: started: testA(a.b.c.MyTest)  // Logged by
> InstrumentationTestRunner

Correct.

> 
> Should we make it clearer that one of these logs come from host side and just
> tag with "test_runner.py"
> 
> I test_runner.py: START testA               // Logged here
> I TestRunner: started: testA(a.b.c.MyTest)  // Logged by
> InstrumentationTestRunner

Switched the tag to test_runner_py.

[mikecase (-- gone --), 2016-10-04 22:15:21]

lgtm

[jbudorick, 2016-10-04 22:15:48]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-10-04 22:16:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 00:15:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 00:17:58]

Description was changed from

==========
[Android] Log instr test start & end.

BUG=651984
==========

to

==========
[Android] Log instr test start & end.

BUG=651984

Committed: https://crrev.com/ddf32ac6c05d9c688aace9f9f7a94b912b29af6a
Cr-Commit-Position: refs/heads/master@{#423012}
==========

[commit-bot: I haz the power, 2016-10-05 00:17:59]

Patchset 2 (id:??) landed as
https://crrev.com/ddf32ac6c05d9c688aace9f9f7a94b912b29af6a
Cr-Commit-Position: refs/heads/master@{#423012}