Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(51)

Issue 2385663002: Version 5.5.335.1 (cherry-pick) (Closed)

Created:
2 years, 10 months ago by Michael Achenbach
Modified:
2 years, 10 months ago
Reviewers:
kozy, Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, PaweĊ‚ Hajdan Jr., ulan
Target Ref:
refs/pending/heads/5.5.335
Project:
v8
Visibility:
Public.

Description

Version 5.5.335.1 (cherry-pick) Merged 0e704cdac6c684c965ed57add4d5bbb9cb7acfdb Revert "[inspector] added inspector test runner [part 1-2]" BUG=chromium:635948 LOG=N TBR=hablich@chromium.org,kozyatinskiy@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/083ad4d4f89e83a6190f4902cacac1727c2d3a93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -542 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M test/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D test/inspector/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D test/inspector/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D test/inspector/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D test/inspector/inspector.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D test/inspector/inspector-impl.h View 1 chunk +0 lines, -76 lines 0 comments Download
D test/inspector/inspector-impl.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D test/inspector/task-runner.h View 1 chunk +0 lines, -79 lines 0 comments Download
D test/inspector/task-runner.cc View 1 chunk +0 lines, -137 lines 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/verify_source_deps.py View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
2 years, 10 months ago (2016-09-30 10:01:11 UTC) #1
Michael Achenbach
Committed patchset #1 (id:1) manually as 083ad4d4f89e83a6190f4902cacac1727c2d3a93.
2 years, 10 months ago (2016-09-30 10:03:02 UTC) #3
Michael Hablich
2 years, 10 months ago (2016-09-30 10:03:22 UTC) #4
Message was sent while issue was closed.
On 2016/09/30 10:03:02, machenbach (slow) wrote:
> Committed patchset #1 (id:1) manually as
> 083ad4d4f89e83a6190f4902cacac1727c2d3a93.

lgtm

Powered by Google App Engine
This is Rietveld 408576698