chrome/browser/storage/durable_storage_permission_context.h - Issue 2385653005: [DurableStorage] Don't grant durable if origin cannot write cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage/durable_storage_permission_context.h

Issue 2385653005: [DurableStorage] Don't grant durable if origin cannot write cookies. (Closed)

Patch Set: Added third party frame check, and incognito check, and fixed cookies check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/storage/durable_storage_permission_context.h

diff --git a/chrome/browser/storage/durable_storage_permission_context.h b/chrome/browser/storage/durable_storage_permission_context.h

index 69ffeb8c6f5dc47385e078b0ab91ccb7e43c19f0..c779e0b7544579e3296ecd48bb58d530f8f2e4be 100644

--- a/chrome/browser/storage/durable_storage_permission_context.h

+++ b/chrome/browser/storage/durable_storage_permission_context.h

@@ -17,7 +17,7 @@ class DurableStoragePermissionContext : public PermissionContextBase {

~DurableStoragePermissionContext() override = default;

// PermissionContextBase implementation.

- // Grant if requesting_origin is bookmarked or already granted.

+ // Grant if requesting_origin is bookmarked.

void DecidePermission(content::WebContents* web_contents,

const PermissionRequestID& id,

const GURL& requesting_origin,