Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: chrome/browser/storage/durable_storage_permission_context.h

Issue 2385653005: [DurableStorage] Don't grant durable if origin cannot write cookies. (Closed)
Patch Set: addressed comments, added test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/storage/durable_storage_permission_context.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_ 5 #ifndef CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_
6 #define CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_ 6 #define CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chrome/browser/permissions/permission_context_base.h" 11 #include "chrome/browser/permissions/permission_context_base.h"
12 #include "components/bookmarks/browser/bookmark_model.h" 12 #include "components/bookmarks/browser/bookmark_model.h"
13 13
14 class DurableStoragePermissionContext : public PermissionContextBase { 14 class DurableStoragePermissionContext : public PermissionContextBase {
15 public: 15 public:
16 explicit DurableStoragePermissionContext(Profile* profile); 16 explicit DurableStoragePermissionContext(Profile* profile);
17 ~DurableStoragePermissionContext() override = default; 17 ~DurableStoragePermissionContext() override = default;
18 18
19 // PermissionContextBase implementation. 19 // PermissionContextBase implementation.
20 // Grant if requesting_origin is bookmarked or already granted. 20 // Grant if requesting_origin is bookmarked.
21 void DecidePermission(content::WebContents* web_contents, 21 void DecidePermission(content::WebContents* web_contents,
22 const PermissionRequestID& id, 22 const PermissionRequestID& id,
23 const GURL& requesting_origin, 23 const GURL& requesting_origin,
24 const GURL& embedding_origin, 24 const GURL& embedding_origin,
25 bool user_gesture, 25 bool user_gesture,
26 const BrowserPermissionCallback& callback) override; 26 const BrowserPermissionCallback& callback) override;
27 void UpdateContentSetting(const GURL& requesting_origin, 27 void UpdateContentSetting(const GURL& requesting_origin,
28 const GURL& embedding_origin, 28 const GURL& embedding_origin,
29 ContentSetting content_setting) override; 29 ContentSetting content_setting) override;
30 bool IsRestrictedToSecureOrigins() const override; 30 bool IsRestrictedToSecureOrigins() const override;
31 31
32 private: 32 private:
33 FRIEND_TEST_ALL_PREFIXES(BookmarksOriginTest, Exists); 33 FRIEND_TEST_ALL_PREFIXES(BookmarksOriginTest, Exists);
34 FRIEND_TEST_ALL_PREFIXES(BookmarksOriginTest, DoesntExist); 34 FRIEND_TEST_ALL_PREFIXES(BookmarksOriginTest, DoesntExist);
35 35
36 static bool IsOriginBookmarked( 36 static bool IsOriginBookmarked(
37 const std::vector<bookmarks::BookmarkModel::URLAndTitle>& bookmarks, 37 const std::vector<bookmarks::BookmarkModel::URLAndTitle>& bookmarks,
38 const GURL& origin); 38 const GURL& origin);
39 39
40 DISALLOW_COPY_AND_ASSIGN(DurableStoragePermissionContext); 40 DISALLOW_COPY_AND_ASSIGN(DurableStoragePermissionContext);
41 }; 41 };
42 42
43 #endif // CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_ 43 #endif // CHROME_BROWSER_STORAGE_DURABLE_STORAGE_PERMISSION_CONTEXT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/storage/durable_storage_permission_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698