Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2385653002: [Test] Don't call deprecated readdir_r in generate-bytecode-expectations. (Closed)

Created:
4 years, 2 months ago by rmcilroy
Modified:
4 years, 2 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Don't call deprecated readdir_r in generate-bytecode-expectations. Committed: https://crrev.com/38c57c5ddb34581370279f13ecf131247b4357d0 Cr-Commit-Position: refs/heads/master@{#39911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M test/cctest/interpreter/generate-bytecode-expectations.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
rmcilroy
PTAL, thanks.
4 years, 2 months ago (2016-09-30 09:59:05 UTC) #5
mythria
lgtm.
4 years, 2 months ago (2016-09-30 10:30:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385653002/1
4 years, 2 months ago (2016-09-30 11:03:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 11:05:25 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 11:05:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38c57c5ddb34581370279f13ecf131247b4357d0
Cr-Commit-Position: refs/heads/master@{#39911}

Powered by Google App Engine
This is Rietveld 408576698