Add WebRange test for explicit empty ranges creation.

Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.

Committed: https://crrev.com/aee6e98a6b9fe3895f9dede7dc9dc858d75a223e
Cr-Commit-Position: refs/heads/master@{#422405}

[mharanczyk, 2016-09-30 10:03:48]

Description was changed from

==========
Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.
==========

to

==========
Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.
==========

[mharanczyk, 2016-09-30 10:03:48]

mharanczyk@opera.com changed reviewers:
+ dglazkov@chromium.org

[mharanczyk, 2016-09-30 10:10:45]

Hi, added test for empty WebRange construction, since the problem was faulty
DCHECK it would fail only in debug builds. The test is quite simple, please
advise if you would like to have it expanded in some way. PTAL.

[dglazkov, 2016-09-30 16:28:23]

lgtm

[mharanczyk, 2016-10-03 08:42:44]

The CQ bit was checked by mharanczyk@opera.com

[commit-bot: I haz the power, 2016-10-03 08:42:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 10:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 10:06:16]

Failed to apply patch for third_party/WebKit/Source/web/tests/WebRangeTest.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/animation/animatable/AnimatableNeutralTest.cpp:28
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/web/tests/WebRangeTest.cpp' with
conflicts.
  U third_party/WebKit/Source/web/tests/WebRangeTest.cpp

Patch:   NR 
third_party/WebKit/Source/core/animation/animatable/AnimatableNeutralTest.cpp->third_party/WebKit/Source/web/tests/WebRangeTest.cpp
Index: third_party/WebKit/Source/web/tests/WebRangeTest.cpp
diff --git
a/third_party/WebKit/Source/core/animation/animatable/AnimatableNeutralTest.cpp
b/third_party/WebKit/Source/web/tests/WebRangeTest.cpp
similarity index 83%
copy from
third_party/WebKit/Source/core/animation/animatable/AnimatableNeutralTest.cpp
copy to third_party/WebKit/Source/web/tests/WebRangeTest.cpp
index
8873e3ec1781d0adcc1785ca802ed86f84b3b509..da184505dc7368543e41d6a2a942d86e398b75d7
100644
---
a/third_party/WebKit/Source/core/animation/animatable/AnimatableNeutralTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebRangeTest.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013, Google Inc. All rights reserved.
+ * Copyright (C) 2017 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
@@ -28,15 +28,21 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "core/animation/animatable/AnimatableNeutral.h"
+#include "public/web/WebRange.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
-TEST(AnimationAnimatableNeutralTest, Create)
+TEST(WebRangeTest, Empty)
 {
-    EXPECT_TRUE(AnimatableValue::neutralValue());
+    WebRange empty1(0, 0);
+    EXPECT_FALSE(empty1.isNull());
+    EXPECT_TRUE(empty1.isEmpty());
+
+    WebRange empty2(57, 0);
+    EXPECT_FALSE(empty2.isNull());
+    EXPECT_TRUE(empty2.isEmpty());
 }
 
 } // namespace blink

[mharanczyk, 2016-10-03 11:21:35]

The CQ bit was checked by mharanczyk@opera.com

[mharanczyk, 2016-10-03 11:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org
Link to the patchset: https://codereview.chromium.org/2385643002/#ps20001
(title: "Rebase and cl format.")

[commit-bot: I haz the power, 2016-10-03 11:21:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 12:32:11]

Description was changed from

==========
Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.
==========

to

==========
Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.
==========

[commit-bot: I haz the power, 2016-10-03 12:32:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 12:34:22]

Description was changed from

==========
Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.
==========

to

==========
Add WebRange test for explicit empty ranges creation.

This is followup of https://codereview.chromium.org/2373613005/.

Committed: https://crrev.com/aee6e98a6b9fe3895f9dede7dc9dc858d75a223e
Cr-Commit-Position: refs/heads/master@{#422405}
==========

[commit-bot: I haz the power, 2016-10-03 12:34:23]

Patchset 2 (id:??) landed as
https://crrev.com/aee6e98a6b9fe3895f9dede7dc9dc858d75a223e
Cr-Commit-Position: refs/heads/master@{#422405}