Unwind WebRTC DTLS 1.2 flag and field trial.

Unwind WebRTC DTLS 1.2 flag and field trial.

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=

Committed: https://crrev.com/89f9a414046cf93ee7ceef9632dffe385a1c9374
Cr-Commit-Position: refs/heads/master@{#423645}

[davidben, 2016-09-30 22:10:42]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[davidben, 2016-09-30 22:11:11]

Description was changed from

==========
Unwind WebRTC DTLS 1.2 flag.

DTLS 1.2 shipped some time ago and this flag is no longer used.

BUG=
==========

to

==========
Unwind WebRTC DTLS 1.2 flag and field trial.

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=
==========

[commit-bot: I haz the power, 2016-09-30 22:11:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-09-30 22:12:23]

davidben@chromium.org changed reviewers:
+ pthatcher@chromium.org

[davidben, 2016-09-30 22:12:24]

pthatcher: I noticed these lying around. It appears they are no longer needed.
Is this correct?

https://codereview.chromium.org/2385623003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (left):

https://codereview.chromium.org/2385623003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:261:
factory_options.ssl_max_version = rtc::SSL_PROTOCOL_DTLS_12;
It seems DTLS 1.2 is the default for
webrtc::PeerConnectionFactoryInterface::Options. Would you prefer this be set
explicitly here or just left at the WebRTC defaults?

[commit-bot: I haz the power, 2016-09-30 22:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:59:39]

Dry run: This issue passed the CQ dry run.

[pthatcher2, 2016-10-06 17:28:02]

lgtm.

Thank you for doing this.  Sorry for the slow review.

https://codereview.chromium.org/2385623003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (left):

https://codereview.chromium.org/2385623003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:261:
factory_options.ssl_max_version = rtc::SSL_PROTOCOL_DTLS_12;
On 2016/09/30 22:12:24, davidben wrote:
> It seems DTLS 1.2 is the default for
> webrtc::PeerConnectionFactoryInterface::Options. Would you prefer this be set
> explicitly here or just left at the WebRTC defaults?

Just leave the default.

[davidben, 2016-10-06 17:32:21]

davidben@chromium.org changed reviewers:
+ avi@chromium.org, isherman@chromium.org

[davidben, 2016-10-06 17:32:22]

+avi for content/
+isherman for testing/variations/

https://codereview.chromium.org/2385623003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (left):

https://codereview.chromium.org/2385623003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:261:
factory_options.ssl_max_version = rtc::SSL_PROTOCOL_DTLS_12;
On 2016/10/06 17:28:01, pthatcher2 wrote:
> On 2016/09/30 22:12:24, davidben wrote:
> > It seems DTLS 1.2 is the default for
> > webrtc::PeerConnectionFactoryInterface::Options. Would you prefer this be
set
> > explicitly here or just left at the WebRTC defaults?
> 
> Just leave the default.

Done.

[Avi (use Gerrit), 2016-10-06 18:04:28]

🎉 yay lgtm

[Ilya Sherman, 2016-10-06 19:05:02]

variations config lgtm

[davidben, 2016-10-06 19:10:12]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-10-06 19:10:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/2385623003/#ps40001
(title: "removed explicit DTLS 1.2 setting in favor of default")

[commit-bot: I haz the power, 2016-10-06 19:10:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:13:44]

Description was changed from

==========
Unwind WebRTC DTLS 1.2 flag and field trial.

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=
==========

to

==========
Unwind WebRTC DTLS 1.2 flag and field trial.

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=
==========

[commit-bot: I haz the power, 2016-10-06 20:13:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 20:15:29]

Description was changed from

==========
Unwind WebRTC DTLS 1.2 flag and field trial.

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=
==========

to

==========
Unwind WebRTC DTLS 1.2 flag and field trial.

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=

Committed: https://crrev.com/89f9a414046cf93ee7ceef9632dffe385a1c9374
Cr-Commit-Position: refs/heads/master@{#423645}
==========

[commit-bot: I haz the power, 2016-10-06 20:15:30]

Patchset 3 (id:??) landed as
https://crrev.com/89f9a414046cf93ee7ceef9632dffe385a1c9374
Cr-Commit-Position: refs/heads/master@{#423645}