|
|
Created:
4 years, 2 months ago by fjhenigman Modified:
4 years, 2 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd angle_unittests to ozone tests.
Without this, nothing is compiling ANGLE's Ozone back end.
BUG=angleproject:1412
Committed: https://crrev.com/3314001d405a79addd34de2ac45f64d2c0d1a893
Cr-Commit-Position: refs/heads/master@{#422982}
Patch Set 1 #Patch Set 2 : Add angle_unittests to ozone tests. #Messages
Total messages: 25 (19 generated)
The CQ bit was checked by fjhenigman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add angle_unittests to ozone tests. BUG=angleproject:1412 ========== to ========== Add angle_unittests to ozone tests. Without this, nothing is compiling ANGLE's Ozone back end. BUG=angleproject:1412 ==========
fjhenigman@chromium.org changed reviewers: + dpranke@chromium.org, jmadill@chromium.org
fjhenigman@chromium.org changed reviewers: + kbr@chromium.org
Anyone know why I can't dry run this?
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Sorry, I don't know this bot and can't review this effectively. I don't know why the tryjobs are failing both with and without your patch. It looks to me like something's broken on that tryserver.
On 2016/09/30 23:07:35, Ken Russell wrote: > Sorry, I don't know this bot and can't review this effectively. > > I don't know why the tryjobs are failing both with and without your patch. It > looks to me like something's broken on that tryserver. The tryserver is fine. The recipe isn't smart enough to figure out that we added a new test binary in the patch and so it's trying to run it both with and without the patch. The problem is that angle_unittests is only referenced from //BUILD.gn from inside an `if (!is_chromeos && !is_ios)` block and from inside an `if (is_win)` block. So, GN doesn't pull in //third_party/angle/src/tests/BUILD.gn, and as a result doesn't know about the target. Fix the definition in //BUILD.gn. lgtm assuming you do that.
The CQ bit was checked by fjhenigman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fjhenigman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2385603002/#ps20001 (title: "Add angle_unittests to ozone tests.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add angle_unittests to ozone tests. Without this, nothing is compiling ANGLE's Ozone back end. BUG=angleproject:1412 ========== to ========== Add angle_unittests to ozone tests. Without this, nothing is compiling ANGLE's Ozone back end. BUG=angleproject:1412 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add angle_unittests to ozone tests. Without this, nothing is compiling ANGLE's Ozone back end. BUG=angleproject:1412 ========== to ========== Add angle_unittests to ozone tests. Without this, nothing is compiling ANGLE's Ozone back end. BUG=angleproject:1412 Committed: https://crrev.com/3314001d405a79addd34de2ac45f64d2c0d1a893 Cr-Commit-Position: refs/heads/master@{#422982} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3314001d405a79addd34de2ac45f64d2c0d1a893 Cr-Commit-Position: refs/heads/master@{#422982} |