Issue 23856009: Add toRenderSVGResourceClipper() fuction, and use it.

Issue 23856009: Add toRenderSVGResourceClipper() fuction, and use it. (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add toRenderSVGResourceClipper() fuction, and use it. This function has type checking assertions for helping to find bad-cast bugs. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157641

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceClipper.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGRenderTreeAsText.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/23856009/diff/1/Source/core/rendering/svg/RenderSVGResourceClipper.h File Source/core/rendering/svg/RenderSVGResourceClipper.h (right): https://codereview.chromium.org/23856009/diff/1/Source/core/rendering/svg/RenderSVGResourceClipper.h#newcode23 Source/core/rendering/svg/RenderSVGResourceClipper.h:23: #include "core/rendering/svg/RenderSVGResource.h" I think we don't need to include ...

7 years, 3 months ago (2013-09-11 21:37:51 UTC) #2

gyuyoung-inactive

On 2013/09/11 21:37:51, tkent wrote: > https://codereview.chromium.org/23856009/diff/1/Source/core/rendering/svg/RenderSVGResourceClipper.h > File Source/core/rendering/svg/RenderSVGResourceClipper.h (right): > > https://codereview.chromium.org/23856009/diff/1/Source/core/rendering/svg/RenderSVGResourceClipper.h#newcode23 > ...

7 years, 3 months ago (2013-09-11 22:35:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23856009/6001

7 years, 3 months ago (2013-09-11 22:51:55 UTC) #5

Message was sent while issue was closed.

Change committed as 157641

Expand Messages | Collapse Messages