chrome/common/print_messages.h - Issue 23855002: Fixing spreadsheets printing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/print_messages.h

Issue 23855002: Fixing spreadsheets printing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/printing/print_view_manager.cc ('k') | chrome/renderer/printing/print_web_view_helper.h » ('j') | chrome/renderer/printing/print_web_view_helper.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for printing.	5 // IPC messages for printing.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 418 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
429 int /* document cookie */)	429 int /* document cookie */)

430	430

431 // Tell the browser print preview found the selected printer has invalid	431 // Tell the browser print preview found the selected printer has invalid

432 // settings (which typically caused by disconnected network printer or printer	432 // settings (which typically caused by disconnected network printer or printer

433 // driver is bogus).	433 // driver is bogus).

434 IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewInvalidPrinterSettings,	434 IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewInvalidPrinterSettings,

435 int /* document cookie */)	435 int /* document cookie */)

436	436

437 // Run a nested message loop in the renderer until print preview for	437 // Run a nested message loop in the renderer until print preview for

438 // window.print() finishes.	438 // window.print() finishes.

439 IPC_SYNC_MESSAGE_ROUTED1_0(PrintHostMsg_ScriptedPrintPreview,	439 IPC_SYNC_MESSAGE_ROUTED0_0(PrintHostMsg_SetupScriptedPrintPreview)

440 bool /* is_modifiable */)	440

	441 // Shows Preview when is_modifiable is availible.
	Lei Zhang 2013/09/04 01:06:34 nit: Without some context, readers are not going t nit: Without some context, readers are not going to understand what "is_modifiable is available" means. How about: // Tell the browser to show the print preview, when the document is sufficiently loaded such that the renderer can determine whether it is modifiable or not. Vitaly Buka (NO REVIEWS) 2013/09/04 01:49:49 Done. Show quoted text On 2013/09/04 01:06:34, Lei Zhang wrote: > nit: Without some context, readers are not going to understand what > "is_modifiable is available" means. How about: > > // Tell the browser to show the print preview, when the document is sufficiently > loaded such that the renderer can determine whether it is modifiable or not. Done.
	442 IPC_MESSAGE_ROUTED1(PrintHostMsg_ShowScriptedPrintPreview,

	443 bool /* is_modifiable */)

441	444

442 // Notify the browser that the PDF in the initiator renderer has disabled print	445 // Notify the browser that the PDF in the initiator renderer has disabled print

443 // scaling option.	446 // scaling option.

444 IPC_MESSAGE_ROUTED0(PrintHostMsg_PrintPreviewScalingDisabled)	447 IPC_MESSAGE_ROUTED0(PrintHostMsg_PrintPreviewScalingDisabled)

OLD	NEW