Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 238543009: ARM64: Fix native builds (Closed)

Created:
6 years, 8 months ago by m.m.capewell
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Fix native builds Rearrange sed lines to enable native builds for ARM64. BUG= R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
m.m.capewell
Sed was replacing aarch64 with arm64, then arm64 with arm, causing host and target mismatch, ...
6 years, 8 months ago (2014-04-16 12:28:47 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-16 12:43:26 UTC) #2
m.m.capewell
6 years, 8 months ago (2014-04-16 13:25:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698