Issue 238543005: Move property addition code from JSObject to Map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238543005: Move property addition code from JSObject to Map (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move property addition code from JSObject to Map BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20791

Patch Set 4 : Addressed comment #

Patch Set 5 : Use MaybeHandle #

Patch Set 6 : MUST_USE_RESULT #

Total comments: 4

Patch Set 7 : Addressed last comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -99 lines)			Patch
M	src/objects.h	View	1 2 3 4 5	4 chunks	+18 lines, -15 lines	0 comments	Download
M	src/objects.cc	View	1 2 3 4 5 6	5 chunks	+85 lines, -73 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	7 chunks	+16 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nits: https://codereview.chromium.org/238543005/diff/90001/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/238543005/diff/90001/src/objects.cc#oldcode1887 src/objects.cc:1887: TransitionFlag flag = attributes != NONE ...

6 years, 8 months ago (2014-04-15 15:02:39 UTC) #2

Toon Verwaest

6 years, 8 months ago (2014-04-16 10:46:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r20791 (presubmit successful).