Issue 238543004: Remove direct calls to number-related allocators from runtime.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238543004: Remove direct calls to number-related allocators from runtime.cc. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove direct calls to number-related allocators from runtime.cc. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20761

Patch Set 2 : changed as suggested #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -120 lines)			Patch
M	src/factory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/factory.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	16 chunks	+88 lines, -116 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm if comment addressed https://codereview.chromium.org/238543004/diff/1/src/runtime.cc File src/runtime.cc (left): https://codereview.chromium.org/238543004/diff/1/src/runtime.cc#oldcode6909 src/runtime.cc:6909: Let's not have behavioral changes ...

6 years, 8 months ago (2014-04-15 11:13:05 UTC) #2

Yang

https://codereview.chromium.org/238543004/diff/1/src/runtime.cc File src/runtime.cc (left): https://codereview.chromium.org/238543004/diff/1/src/runtime.cc#oldcode6909 src/runtime.cc:6909: On 2014/04/15 11:13:06, Dmitry Lomov (chromium) wrote: > Let's ...

6 years, 8 months ago (2014-04-15 11:14:28 UTC) #3

Yang

6 years, 8 months ago (2014-04-15 11:16:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20761 (presubmit successful).

Expand Messages | Collapse Messages

Issue 238543004: Remove direct calls to number-related allocators from runtime.cc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : changed as suggested #

Messages