Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385423004: Rename fpdfsdk/fpdfxfa files to match contents (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename fpdfsdk/fpdfxfa files to match contents Each of these files contains a single class, rename the file to match the internal class name. Committed: https://pdfium.googlesource.com/pdfium/+/4d29e78fc80285d222f2bad916354e3db970d0cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1195 lines) Patch
M BUILD.gn View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/cpdfsdk_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_environment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_app.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_app.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_document.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_document.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_page.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_page.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_app.h View 1 chunk +0 lines, -79 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +0 lines, -341 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_doc.h View 1 chunk +0 lines, -95 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +0 lines, -201 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_page.h View 1 chunk +0 lines, -85 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +0 lines, -224 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_util.h View 1 chunk +0 lines, -48 lines 0 comments Download
D fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M fpdfsdk/fsdk_define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-04 20:49:39 UTC) #2
npm
lgtm
4 years, 2 months ago (2016-10-04 20:54:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385423004/1
4 years, 2 months ago (2016-10-04 20:56:09 UTC) #8
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-04 20:58:03 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:02:51 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4d29e78fc80285d222f2bad916354e3db970...

Powered by Google App Engine
This is Rietveld 408576698