Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2385413003: Thread safe initialization of OSCrypt cache (Closed)

Created:
4 years, 2 months ago by vabr (Chromium)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Thread safe initialization of OSCrypt cache Clients of OSCrypt run in multiple threads. This creates a race condition for the lazy initialization of OSCrypt, which currently isn't thread safe. Additionally, when a synchronous call to libsecret blocks waiting for user permission, parallel calls to it do not block on the same prompt. Rather, they fail. This means that, while the first caller will correctly identify that encryption should be used, subsequent callers will behave as if full encryption is not available, until the first caller gets permission and properly initialises OSCrypt. Fixing thread safety should fix reported cases of data loss. BUG=631171 Review-Url: https://codereview.chromium.org/2359803002 Cr-Commit-Position: refs/heads/master@{#421097} (cherry picked from commit fc6f304827896fb27397fc2a27f9f5717eff319c)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M components/os_crypt/os_crypt.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/os_crypt/os_crypt_linux.cc View 4 chunks +16 lines, -6 lines 0 comments Download
M components/os_crypt/os_crypt_unittest.cc View 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vabr (Chromium)
4 years, 2 months ago (2016-10-04 14:35:41 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
0c69d0e83f5d4f987294067bfa2a8ada5c4b095e.

Powered by Google App Engine
This is Rietveld 408576698