Move Webapp launch code to WebappLauncherActivity#launch() to enable early returns

Move Webapp launch code to WebappLauncherActivity#launch() to enable early returns

This CL moves most of the logic in WebappLauncherActivity#onCreate() to
WebappLauncherActivity#launch() in order to enable
WebappLauncherActivity#launch() to early return. This is in preparation to
fixing http://crbug.com/651640 which will add more code paths to
WebappLauncherActivity#launch()

BUG=651640
TEST=None

Committed: https://crrev.com/f16aacf71eddfb0d9be72a22b53754640b2d42f4
Cr-Commit-Position: refs/heads/master@{#424088}

[pkotwicz, 2016-10-03 23:37:09]

Description was changed from

==========
Move Webapp launch code to WebappLauncherActivity#launch() to enable early
returns

This CL:
- Removes the duplicate checking for whether the id is null and the uri is null
  in WebappLauncherActivity#onCreate()
  WebappInfo#create() returns null if either the id or the uri is null.
-
==========

to

==========
Move Webapp launch code to WebappLauncherActivity#launch() to enable early
returns

This CL moves most of the logic in WebappLauncherActivity#onCreate() to
WebappLauncherActivity#launch() in order to enable
WebappLauncherActivity#launch() to early return. This is in preparation to
fixing http://crbug.com/651640 which will add more code paths to
WebappLauncherActivity#launch()

BUG=651640
TEST=None
==========

[pkotwicz, 2016-10-03 23:37:09]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-10-03 23:37:32]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-10-03 23:41:35]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2016-10-03 23:44:21]

Dominick, can you please take a look? This CL depends on
https://codereview.chromium.org/2386383002/

[dominickn, 2016-10-04 03:35:10]

https://codereview.chromium.org/2385413002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
(right):

https://codereview.chromium.org/2385413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java:50:
public void launch() {
Nit: call this launchActivity()

https://codereview.chromium.org/2385413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java:54:
// {@link WebappInfo#create()} returns null if the intent does not specify the
id or the
Move this comment above the if statement. Then make the if statement one line.
You should also be able to make the comment one line.

https://codereview.chromium.org/2385413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java:58:
String webappId = webappInfo.id();
This variable doesn't seem to be used anywhere.

[pkotwicz, 2016-10-06 19:43:00]

Dominick can you please take another look?

https://codereview.chromium.org/2385413002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
(right):

https://codereview.chromium.org/2385413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java:54:
// {@link WebappInfo#create()} returns null if the intent does not specify the
id or the
Done. The comment unfortunately did not fit on one line

[dominickn, 2016-10-07 00:09:21]

lgtm

[pkotwicz, 2016-10-07 14:48:47]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-10-07 14:49:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 14:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 14:51:33]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pkotwicz, 2016-10-09 00:27:55]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-10-09 00:27:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2385413002/#ps80001
(title: "Merge branch 'master' into security0")

[commit-bot: I haz the power, 2016-10-09 00:28:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-09 00:57:12]

Description was changed from

==========
Move Webapp launch code to WebappLauncherActivity#launch() to enable early
returns

This CL moves most of the logic in WebappLauncherActivity#onCreate() to
WebappLauncherActivity#launch() in order to enable
WebappLauncherActivity#launch() to early return. This is in preparation to
fixing http://crbug.com/651640 which will add more code paths to
WebappLauncherActivity#launch()

BUG=651640
TEST=None
==========

to

==========
Move Webapp launch code to WebappLauncherActivity#launch() to enable early
returns

This CL moves most of the logic in WebappLauncherActivity#onCreate() to
WebappLauncherActivity#launch() in order to enable
WebappLauncherActivity#launch() to early return. This is in preparation to
fixing http://crbug.com/651640 which will add more code paths to
WebappLauncherActivity#launch()

BUG=651640
TEST=None
==========

[commit-bot: I haz the power, 2016-10-09 00:57:13]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-09 00:59:26]

Description was changed from

==========
Move Webapp launch code to WebappLauncherActivity#launch() to enable early
returns

This CL moves most of the logic in WebappLauncherActivity#onCreate() to
WebappLauncherActivity#launch() in order to enable
WebappLauncherActivity#launch() to early return. This is in preparation to
fixing http://crbug.com/651640 which will add more code paths to
WebappLauncherActivity#launch()

BUG=651640
TEST=None
==========

to

==========
Move Webapp launch code to WebappLauncherActivity#launch() to enable early
returns

This CL moves most of the logic in WebappLauncherActivity#onCreate() to
WebappLauncherActivity#launch() in order to enable
WebappLauncherActivity#launch() to early return. This is in preparation to
fixing http://crbug.com/651640 which will add more code paths to
WebappLauncherActivity#launch()

BUG=651640
TEST=None

Committed: https://crrev.com/f16aacf71eddfb0d9be72a22b53754640b2d42f4
Cr-Commit-Position: refs/heads/master@{#424088}
==========

[commit-bot: I haz the power, 2016-10-09 00:59:27]

Patchset 3 (id:??) landed as
https://crrev.com/f16aacf71eddfb0d9be72a22b53754640b2d42f4
Cr-Commit-Position: refs/heads/master@{#424088}