Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/wasm/test-run-wasm-simd.cc

Issue 2385393002: [wasm] Implement I32x4ReplaceLane, I32x4Add, I32x4Sub. (Closed)
Patch Set: Bill's review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/wasm/ast-decoder.cc ('K') | « src/wasm/wasm-opcodes.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-simd.cc
diff --git a/test/cctest/wasm/test-run-wasm-simd.cc b/test/cctest/wasm/test-run-wasm-simd.cc
index 76eac5e793e77c43a1f1041619813576828f4868..979954830eb2d37a980d8c42d4e743f9eb221a22 100644
--- a/test/cctest/wasm/test-run-wasm-simd.cc
+++ b/test/cctest/wasm/test-run-wasm-simd.cc
@@ -13,7 +13,11 @@ using namespace v8::internal;
using namespace v8::internal::compiler;
using namespace v8::internal::wasm;
-WASM_EXEC_TEST(Splat) {
+// TODO(gdeepti): These are tests using sample values to verify functional
+// correctness of opcodes, add more tests for a range of values and macroize
+// tests.
+
+WASM_EXEC_TEST(I32x4Splat) {
FLAG_wasm_simd_prototype = true;
// Store SIMD value in a local variable, use extract lane to check lane values
@@ -47,3 +51,200 @@ WASM_EXEC_TEST(Splat) {
FOR_INT32_INPUTS(i) { CHECK_EQ(1, r.Call(*i)); }
}
+
+WASM_EXEC_TEST(I32x4ReplaceLane) {
+ FLAG_wasm_simd_prototype = true;
+ WasmRunner<int32_t> r(kExecuteCompiled, MachineType::Int32());
+ r.AllocateLocal(kAstS128);
+ BUILD(r,
+ WASM_BLOCK(
+ // (0xaced, 0xaced, 0xaced, 0xaced)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(0))),
+ // (0xabcd, 0xaced, 0xaced, 0xaced)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(0, WASM_GET_LOCAL(1),
+ WASM_I32V(0xabcd))),
+ // (0xabcd, 0xbcde, 0xaced, 0xaced)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(1, WASM_GET_LOCAL(1),
+ WASM_I32V(0xbcde))),
+ // (0xabcd, 0xbcde, 0xaced, 0xcdef)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(2, WASM_GET_LOCAL(1),
+ WASM_I32V(0xcdef))),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xabcd), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 0, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xbcde), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 1, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xcdef), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 2, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xaced), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 3, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_RETURN1(WASM_ONE)));
+
+ CHECK_EQ(1, r.Call(0xaced));
+}
+
+WASM_EXEC_TEST(I32x4Add) {
titzer 2016/10/07 12:20:14 I think these tests can get a bit simpler. E.g. wh
gdeepti 2016/11/22 01:15:20 bbudge@ suggested using only splat values instead
+ FLAG_wasm_simd_prototype = true;
+ WasmRunner<int32_t> r(kExecuteCompiled, MachineType::Int32(),
+ MachineType::Int32());
+ r.AllocateLocal(kAstS128);
+ r.AllocateLocal(kAstS128);
+ BUILD(r,
+ WASM_BLOCK(
+ // (0x1111, 0x1111, 0x1111, 0x1111)
+ WASM_SET_LOCAL(2, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(0))),
+ // (0x2222, 0x2222, 0x2222, 0x2222)
+ WASM_SET_LOCAL(3, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(1))),
+ // (0x3333, 0x3333, 0x3333, 0x3333)
+ WASM_SET_LOCAL(
+ 3, WASM_SIMD_I32x4_ADD(WASM_GET_LOCAL(2), WASM_GET_LOCAL(3))),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x3333), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 0, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x3333), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 1, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x3333), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 2, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x3333), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 3, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_RETURN1(WASM_ONE)));
+
+ CHECK_EQ(1, r.Call(0x1111, 0x2222));
+}
+
+WASM_EXEC_TEST(I32x4Sub) {
+ FLAG_wasm_simd_prototype = true;
+
+ WasmRunner<int32_t> r(kExecuteCompiled, MachineType::Int32(),
+ MachineType::Int32());
+ r.AllocateLocal(kAstS128);
+ r.AllocateLocal(kAstS128);
+ BUILD(r,
+ WASM_BLOCK(
+ // (0xbf21, 0xbf21, 0xbf21, 0xbf21)
+ WASM_SET_LOCAL(2, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(0))),
+ // (0x1234, 0x1234, 0x1234, 0x1234)
+ WASM_SET_LOCAL(3, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(1))),
+ // (0xaced, 0xaced, 0xaced, 0xaced)
+ WASM_SET_LOCAL(
+ 3, WASM_SIMD_I32x4_SUB(WASM_GET_LOCAL(2), WASM_GET_LOCAL(3))),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xaced), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 0, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xaced), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 1, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xaced), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 2, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xaced), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 3, WASM_GET_LOCAL(3))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_RETURN1(WASM_ONE)));
+
+ CHECK_EQ(1, r.Call(0xBF21, 0x1234));
+}
+
+WASM_EXEC_TEST(I32x4AddReplace) {
+ FLAG_wasm_simd_prototype = true;
+ WasmRunner<int32_t> r(kExecuteCompiled);
+ r.AllocateLocal(kAstS128);
+ r.AllocateLocal(kAstS128);
+ BUILD(r,
+ WASM_BLOCK(
+ // (0x1357, 0x1357, 0x1357, 0x1357)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_SPLAT(WASM_I32V(0x1357))),
+ // (0x3579, 0x1357, 0x1357, 0x1357)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_REPLACE_LANE(0, WASM_GET_LOCAL(0),
+ WASM_I32V(0x3579))),
+ // (0x3579, 0x5791, 0x1357, 0x1357)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_REPLACE_LANE(1, WASM_GET_LOCAL(0),
+ WASM_I32V(0x5791))),
+ // (0x3579, 0x5791, 0x7915, 0x1357)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_REPLACE_LANE(2, WASM_GET_LOCAL(0),
+ WASM_I32V(0x7915))),
+ // (0x5432, 0x5432, 0x5432, 0x5432)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_SPLAT(WASM_I32V(0x5432))),
+ // (0x3219, 0x5432, 0x5432, 0x5432)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(0, WASM_GET_LOCAL(1),
+ WASM_I32V(0x3219))),
+ // (0x3219, 0x2198, 0x5432, 0x5432)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(1, WASM_GET_LOCAL(1),
+ WASM_I32V(0x2198))),
+ // (0x3219, 0x2198, 0x1987, 0x5432)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(2, WASM_GET_LOCAL(1),
+ WASM_I32V(0x1987))),
+ // (0x6792, 0x7929, 0x929c, 0x6789)
+ WASM_SET_LOCAL(
+ 0, WASM_SIMD_I32x4_ADD(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1))),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x6792), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 0, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x7929), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 1, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x929c), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 2, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x6789), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 3, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_RETURN1(WASM_ONE)));
+
+ CHECK_EQ(1, r.Call());
+}
+
+WASM_EXEC_TEST(I32x4SubReplace) {
+ FLAG_wasm_simd_prototype = true;
+ WasmRunner<int32_t> r(kExecuteCompiled);
+ r.AllocateLocal(kAstS128);
+ r.AllocateLocal(kAstS128);
+ BUILD(r,
+ WASM_BLOCK(
+ // (0xfedc, 0xfedc, 0xfedc, 0xfedc)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_SPLAT(WASM_I32V(0xfedc))),
+ // (0xcba9, 0xfedc, 0xfedc, 0xfedc)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_REPLACE_LANE(0, WASM_GET_LOCAL(0),
+ WASM_I32V(0xcba9))),
+ // (0xcba9, 0xdcba, 0xfedc, 0xfedc)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_REPLACE_LANE(1, WASM_GET_LOCAL(0),
+ WASM_I32V(0xdcba))),
+ // (0xcba9, 0xdcba, 0xedcb, 0xfedc)
+ WASM_SET_LOCAL(0, WASM_SIMD_I32x4_REPLACE_LANE(2, WASM_GET_LOCAL(0),
+ WASM_I32V(0xedcb))),
+ // (0x1234, 0x1234, 0x1234, 0x1234)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_SPLAT(WASM_I32V(0x1234))),
+ // (0x4567, 0x1234, 0x1234, 0x1234)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(0, WASM_GET_LOCAL(1),
+ WASM_I32V(0x4567))),
+ // (0x4567, 0x3456, 0x1234, 0x1234)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(1, WASM_GET_LOCAL(1),
+ WASM_I32V(0x3456))),
+ // (0x4567, 0x3456, 0x2345, 0x1234)
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_REPLACE_LANE(2, WASM_GET_LOCAL(1),
+ WASM_I32V(0x2345))),
+ // (0x8642, 0xa864, 0xca86, 0xeca8)
+ WASM_SET_LOCAL(
+ 0, WASM_SIMD_I32x4_SUB(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1))),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0x8642), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 0, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xa864), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 1, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xca86), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 2, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_I32V(0xeca8), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 3, WASM_GET_LOCAL(0))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_RETURN1(WASM_ONE)));
+
+ CHECK_EQ(1, r.Call());
+}
« src/wasm/ast-decoder.cc ('K') | « src/wasm/wasm-opcodes.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698