src/compiler/x64/instruction-scheduler-x64.cc - Issue 2385393002: [wasm] Implement I32x4ReplaceLane, I32x4Add, I32x4Sub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-scheduler-x64.cc

Issue 2385393002: [wasm] Implement I32x4ReplaceLane, I32x4Add, I32x4Sub. (Closed)

Patch Set: Add lanes as compile time constants Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-scheduler-x64.cc

diff --git a/src/compiler/x64/instruction-scheduler-x64.cc b/src/compiler/x64/instruction-scheduler-x64.cc

index 05a3e4c3ad53e8bb792994e54999332365c8793d..427e58083f6dd672ea6b9c259cc9a9eefbf2233c 100644

--- a/src/compiler/x64/instruction-scheduler-x64.cc

+++ b/src/compiler/x64/instruction-scheduler-x64.cc

@@ -125,6 +125,9 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kX64Inc32:

case kX64Int32x4Create:

case kX64Int32x4ExtractLane:

+ case kX64Int32x4ReplaceLane:

+ case kX64Int32x4Add:

+ case kX64Int32x4Sub:

return (instr->addressing_mode() == kMode_None)

? kNoOpcodeFlags

: kIsLoadOperation | kHasSideEffect;