[wasm] Implement I32x4ReplaceLane, I32x4Add, I32x4Sub.

src/wasm/ast-decoder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/signature.h"
 
 #include "src/bit-vector.h"
 #include "src/flags.h"
 #include "src/handles.h"
 #include "src/zone/zone-containers.h"
@@ skipping 1230 matching lines @@
     Value val = Pop(1, type);
     Value index = Pop(0, kAstI32);
     BUILD(StoreMem, mem_type, index.node, operand.offset, operand.alignment,
           val.node, position());
     return 1 + operand.length;
   }
 
   unsigned DecodeSimdOpcode(WasmOpcode opcode) {
     unsigned len = 0;
     switch (opcode) {
-      case kExprI32x4ExtractLane: {
+      case kExprI32x4ReplaceLane: {
+        compiler::NodeVector inputs(3, zone_);
+        inputs[2] = Pop(1, LocalType::kWord32).node;
         uint8_t lane = this->checked_read_u8(pc_, 2, "lane number");
         if (lane < 0 || lane > 3) {
           error(pc_, pc_ + 2, "invalid extract lane value");

[bbudge, 2016/10/04 20:34:26]

s/extract/replace

I think there are enough SIMD instructions that take immediate values for lanes
that it would be worthwhile to extract a helper method to read an immediate
value, range check, and create the Int32Constant input. This will eliminate a
lot of repetitive code. The only downside is that the error message would have
to be more generic, e.g. "invalid immediate value" but I think the error message
and pc information is enough information.

Also, you should clamp out-of-range values to the legal range here so we don't
have to worry about weird behavior in the assembler. Or does the call to 'error'
make that unnecessary?

[gdeepti, 2016/11/22 01:15:20]

Using LaneOperand as introduced in the ScalarLowering pass that introduces
LaneOperand. The validate function verifies that the lane values are in the
right range. I think error returns a decode error so it does not go to the
assembler. 

         }
-        TFNode* input = Pop(0, LocalType::kSimd128).node;
-        TFNode* node = BUILD(SimdExtractLane, opcode, lane, input);
+        inputs[1] = builder_->Int32Constant(lane);
+        inputs[0] = Pop(0, LocalType::kSimd128).node;
+        TFNode* node = BUILD(SimdOp, opcode, inputs);
+        Push(LocalType::kSimd128, node);
+        len++;
+        break;
+      }
+      case kExprI32x4ExtractLane: {
+        compiler::NodeVector inputs(2, zone_);
+        inputs[0] = Pop(0, LocalType::kSimd128).node;
+        uint8_t lane = this->checked_read_u8(pc_, 2, "lane number");
+        if (lane < 0 || lane > 3) {
+          error(pc_, pc_ + 2, "invalid extract lane value");
+        }
+        inputs[1] = builder_->Int32Constant(lane);
+        TFNode* node = BUILD(SimdOp, opcode, inputs);
         Push(LocalType::kWord32, node);
         len++;
         break;
       }
       default: {
         FunctionSig* sig = WasmOpcodes::Signature(opcode);
         if (sig != nullptr) {
           compiler::NodeVector inputs(sig->parameter_count(), zone_);
           for (size_t i = sig->parameter_count(); i > 0; i--) {
             Value val = Pop(static_cast<int>(i - 1), sig->GetParam(i - 1));
@@ skipping 665 matching lines @@
 BitVector* AnalyzeLoopAssignmentForTesting(Zone* zone, size_t num_locals,
                                            const byte* start, const byte* end) {
   FunctionBody body = {nullptr, nullptr, nullptr, start, end};
   WasmFullDecoder decoder(zone, nullptr, body);
   return decoder.AnalyzeLoopAssignmentForTesting(start, num_locals);
 }
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8