Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2385383002: DevTools: Update ExecutionContext warning on external changes (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Update ExecutionContext warning on external changes BUG=640268 Committed: https://crrev.com/a4203f3c99cd77cf9744b0983451d5b20fe4fb3d Cr-Commit-Position: refs/heads/master@{#422853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 2 months ago (2016-10-03 22:27:19 UTC) #2
dgozman
lgtm
4 years, 2 months ago (2016-10-03 22:42:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385383002/1
4 years, 2 months ago (2016-10-04 17:37:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 17:47:02 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:51:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4203f3c99cd77cf9744b0983451d5b20fe4fb3d
Cr-Commit-Position: refs/heads/master@{#422853}

Powered by Google App Engine
This is Rietveld 408576698