Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2385373003: Fix webkit-patch --help. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix webkit-patch --help. I believe that after http://crrev.com/2276713002, invoking webkit-patch with --help rather than help was broken. When `webkit-patch help` is invoked, the codepath that's used goes through the execute method of HelpCommand, and the _tool attribute is set, so it worked. But when --help is passed, a different codepath is used, that goes through optparse which directly uses HelpCommand.help_epilog and the _tool attribute was never set. This CL fixes this case by setting the _tool attribute in the constructor of HelpCommand. Committed: https://crrev.com/3d1a19a2bd38572c918334f68d83b36989ea557b Cr-Commit-Position: refs/heads/master@{#423017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/help_command.py View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch_unittest.py View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 2 months ago (2016-10-04 21:09:15 UTC) #2
jeffcarp
lgtm
4 years, 2 months ago (2016-10-04 22:54:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385373003/1
4 years, 2 months ago (2016-10-04 23:25:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:25:47 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:31:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1a19a2bd38572c918334f68d83b36989ea557b
Cr-Commit-Position: refs/heads/master@{#423017}

Powered by Google App Engine
This is Rietveld 408576698