components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 2385363002: Pass the RenderProcessHost id on retargeting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 2385363002: Pass the RenderProcessHost id on retargeting. (Closed)

Patch Set: Address review feedback and compile problem. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index 8e309d5a00bfdbb90aeaef0ac711ccbccd09019f..1468e809c2b6982653399548be4212c165279cc6 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -209,8 +209,11 @@ bool WebContentsDelegateAndroid::OnGoToEntryOffset(int offset) {

}

void WebContentsDelegateAndroid::WebContentsCreated(

- WebContents* source_contents, int opener_render_frame_id,

- const std::string& frame_name, const GURL& target_url,

+ WebContents* source_contents,

+ int opener_render_process_id,

+ int opener_render_frame_id,

+ const std::string& frame_name,

+ const GURL& target_url,

WebContents* new_contents) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);