Make ChromeVox use child-index based offsets again for selection.

Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either passing offsets before or after the line break. Make the index adjument walk up to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000, 641728
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a7d8eae7194d623c7e2ff753f79524da9864af7e
Cr-Commit-Position: refs/heads/master@{#424782}

[David Tseng, 2016-10-03 21:01:46]

Description was changed from

==========
Make ChromeVox use child-index based offsets again for selection.
==========

to

==========
Make ChromeVox use child-index based offsets again for selection.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-03 21:42:21]

Description was changed from

==========
Make ChromeVox use child-index based offsets again for selection.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-03 21:42:22]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-10-03 21:44:21]

Description was changed from

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000,641728
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-10-05 18:25:33]

lgtm

If you select a <br> element using JavaScript APIs
does it give you a non-empty selection? If you get
the text do you get a "\n" or do you get nothing?
Just curious what we should expect. It could be
WAI.

https://codereview.chromium.org/2385343002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
(right):

https://codereview.chromium.org/2385343002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js:512:
window.setTimeout(function() {
Have you looked into this API, would it work?

https://developer.chrome.com/apps/clipboard

[David Tseng, 2016-10-10 20:03:21]

Wrt selecting br...

it works great in the DOM. To be clear, I did:
var br = document.querySelector('br');
var s = getSelection();
s.removeAllRanges();
var r = document.createRange();
r.selectNode(br);
s.toString() == '\n';
> true

In AX, we just quietly return *nothing*. It's a text offset selection issue.
When I use a non-text based offset on the parenting nodes, it works fine.

Again, we just need to understand the code a little better and make a wholeistic
fix rather than all of these one-off suprises.

https://codereview.chromium.org/2385343002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
(right):

https://codereview.chromium.org/2385343002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js:512:
window.setTimeout(function() {
On 2016/10/05 18:25:33, dmazzoni_ooo_until_oct_10 wrote:
> Have you looked into this API, would it work?
> 
> https://developer.chrome.com/apps/clipboard

This didn't work for me when I first tried it a while ago. 

Wasted some time trying to figure out why it wasn't working...looks like only
platform apps have clipboard perms and only on dev. Tried to whitelist
ChromeVox, but no go. Guessing I'm missing something along the way, but
considering the api is still in dev, let's re-visit when it actually works.

[David Tseng, 2016-10-10 20:04:26]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:04:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:08:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-10-12 16:42:54]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-12 16:42:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2385343002/#ps20001
(title: "Fix test")

[commit-bot: I haz the power, 2016-10-12 16:43:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 17:42:21]

Description was changed from

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000,641728
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000,641728
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-12 17:42:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 17:49:47]

Description was changed from

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000,641728
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either
passing offsets before or after the line break. Make the index adjument walk up
to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied
text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG=642000,641728
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a7d8eae7194d623c7e2ff753f79524da9864af7e
Cr-Commit-Position: refs/heads/master@{#424782}
==========

[commit-bot: I haz the power, 2016-10-12 17:49:48]

Patchset 2 (id:??) landed as
https://crrev.com/a7d8eae7194d623c7e2ff753f79524da9864af7e
Cr-Commit-Position: refs/heads/master@{#424782}