Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)
Patch Set: Move guest ctor to private Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_widget_host_view_guest.h" 5 #include "content/browser/frame_host/render_widget_host_view_guest.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 private: 59 private:
60 RenderWidgetHostImpl* host_; 60 RenderWidgetHostImpl* host_;
61 float scale_factor_; 61 float scale_factor_;
62 62
63 DISALLOW_COPY_AND_ASSIGN(ScopedInputScaleDisabler); 63 DISALLOW_COPY_AND_ASSIGN(ScopedInputScaleDisabler);
64 }; 64 };
65 65
66 } // namespace 66 } // namespace
67 67
68 // static
69 RenderWidgetHostViewGuest* RenderWidgetHostViewGuest::Create(
70 RenderWidgetHost* widget,
71 BrowserPluginGuest* guest,
72 base::WeakPtr<RenderWidgetHostViewBase> platform_view) {
73 RenderWidgetHostViewGuest* view =
74 new RenderWidgetHostViewGuest(widget, guest, platform_view);
75 view->Init();
76 return view;
77 }
78
68 RenderWidgetHostViewGuest::RenderWidgetHostViewGuest( 79 RenderWidgetHostViewGuest::RenderWidgetHostViewGuest(
69 RenderWidgetHost* widget_host, 80 RenderWidgetHost* widget_host,
70 BrowserPluginGuest* guest, 81 BrowserPluginGuest* guest,
71 base::WeakPtr<RenderWidgetHostViewBase> platform_view) 82 base::WeakPtr<RenderWidgetHostViewBase> platform_view)
72 : RenderWidgetHostViewChildFrame(widget_host), 83 : RenderWidgetHostViewChildFrame(widget_host),
73 // |guest| is NULL during test. 84 // |guest| is NULL during test.
74 guest_(guest ? guest->AsWeakPtr() : base::WeakPtr<BrowserPluginGuest>()), 85 guest_(guest ? guest->AsWeakPtr() : base::WeakPtr<BrowserPluginGuest>()),
75 platform_view_(platform_view) { 86 platform_view_(platform_view) {
76 gfx::NativeView view = GetNativeView(); 87 gfx::NativeView view = GetNativeView();
77 if (view) 88 if (view)
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 gesture_event.data.scrollUpdate.inertialPhase == 688 gesture_event.data.scrollUpdate.inertialPhase ==
678 blink::WebGestureEvent::MomentumPhase) { 689 blink::WebGestureEvent::MomentumPhase) {
679 return; 690 return;
680 } 691 }
681 host_->ForwardGestureEvent(gesture_event); 692 host_->ForwardGestureEvent(gesture_event);
682 return; 693 return;
683 } 694 }
684 } 695 }
685 696
686 } // namespace content 697 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698