RenderWidgetHostViewChildFrame's called a virtual in its ctor.

content/browser/renderer_host/render_widget_host_view_aura.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 514 matching lines @@
   // Helper function to create a selection controller.
   void CreateSelectionController();
 
   // Performs gesture handling needed for touch text selection. Sets event as
   // handled if it should not be further processed.
   void HandleGestureForTouchSelection(ui::GestureEvent* event);
 
   // Forwards a mouse event to this view's parent window delegate.
   void ForwardMouseEventToParent(ui::MouseEvent* event);
 
+  void UpdateNeedsBeginFramesInternal();

[clamy, 2016/10/05 12:35:53]

How is this change (and the similar ones about needs_begin_frames_internal)
related to the issue of the virtual being called in the ctor?

[dtapuska, 2016/10/05 13:21:29]

So I tried to land a change that did vsync aligned synthetic gestures (see
https://codereview.chromium.org/2372873003/) which had part of this CL. 

And this caused a regression because when SetView is called (in the ctor)
SetNeedsBeginFrame method is called
https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_wid...

but its state is completely wrong.

If I don't carry forward some of that original change (as here); it fails an
assert because the frame observer is added twice. And there is a DCHECK that the
frame observer only be added once in the listener table.

[clamy, 2016/10/05 13:47:01]

Ok so let me see if I get this right (sorry not super familiar with this area of
the code): the virtual method that ends up getting called in the
RenderWidgetHostViewChildFrame ctor is SetNeedsBeginFrame? And because it was
called before RenderWidgetHostViewGuest vtable had been populated it didn't
actually do what it was supposed to do, but now that it does it triggers an
assert, hence the change to UpdateNeedsBeginFramesInternal?

If so, could you please update the CL description by adding the name of the
problematic method & explaining that this also required some modification to the
implementation of the method in some inheriting classes now that the proper
version is being called in the ctor? That wasn't immediately clear when reading
it.

+
   // Returns the RenderViewHostDelegateView instance for this view. Returns
   // NULL on failure.
   RenderViewHostDelegateView* GetRenderViewHostDelegateView();
 
   // The model object.
   RenderWidgetHostImpl* const host_;
 
   aura::Window* window_;
 
   std::unique_ptr<DelegatedFrameHost> delegated_frame_host_;
@@ skipping 40 matching lines @@
 
   // Whether return characters should be passed on to the RenderWidgetHostImpl.
   bool accept_return_character_;
 
   // Current tooltip text.
   base::string16 tooltip_;
 
   // The begin frame source being observed.  Null if none.
   cc::BeginFrameSource* begin_frame_source_;
   cc::BeginFrameArgs last_begin_frame_args_;
+
+  // Whether a request for begin frames has been issued.
   bool needs_begin_frames_;
 
+  // Whether or not a frame observer has been added.
+  bool added_frame_observer_;
+
   // Used to record the last position of the mouse.
   // While the mouse is locked, they store the last known position just as mouse
   // lock was entered.
   // Relative to the upper-left corner of the view.
   gfx::Point unlocked_mouse_position_;
   // Relative to the upper-left corner of the screen.
   gfx::Point unlocked_global_mouse_position_;
   // Last cursor position relative to screen. Used to compute movementX/Y.
   gfx::Point global_mouse_position_;
   // In mouse locked mode, we synthetically move the mouse cursor to the center
@@ skipping 80 matching lines @@
   int32_t last_active_widget_routing_id_;
 
   base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_