Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 238533002: Use Traits in V8StringResource to avoid code duplication (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
haraken, adamk
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Use Traits in V8StringResource to avoid code duplication Use Traits in V8StringResource to avoid code duplication in StringTraits::fromV8String() for 1-byte / 2-bytes v8::String. This also gets rid of template specializations for the oneByte boolean argument which makes the code a bit clearer as fromV8String<false> / fromV8String<true> was not very readable. There is no visible impact on performance according to Dromaeo DOM Core: http://dromaeo.com/?id=219949,219955 The binary size is slightly smaller (184 bytes), likely because the compiler is able to simplify the code further as fromV8String() is now implicitly inlined but it wasn't before due to template specialization. R=haraken@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171677

Patch Set 1 #

Patch Set 2 : Slight clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -38 lines) Patch
M Source/bindings/v8/V8StringResource.cpp View 1 4 chunks +28 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 8 months ago (2014-04-15 02:08:56 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-15 02:18:42 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-15 19:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/238533002/20001
6 years, 8 months ago (2014-04-15 19:22:22 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:30:19 UTC) #5
Message was sent while issue was closed.
Change committed as 171677

Powered by Google App Engine
This is Rietveld 408576698