core/fpdfdoc/cpdf_interform.cpp - Issue 2385293002: Make CPDF_Object containers hold objects via unique pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_interform.cpp

Issue 2385293002: Make CPDF_Object containers hold objects via unique pointers (Closed)

Patch Set: Remove duplicated line Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_interform.cpp

diff --git a/core/fpdfdoc/cpdf_interform.cpp b/core/fpdfdoc/cpdf_interform.cpp

index b8b4b68e297efba6ac0a65c497b1ab2717024234..3bef85ef9ce1b9b85f7724f8efd235f84b8e6041 100644

--- a/core/fpdfdoc/cpdf_interform.cpp

+++ b/core/fpdfdoc/cpdf_interform.cpp

@@ -138,7 +138,7 @@ CPDF_Font* GetNativeFont(CPDF_Dictionary* pFormDict,

for (const auto& it : *pFonts) {

const CFX_ByteString& csKey = it.first;

- CPDF_Object* pObj = it.second;

+ CPDF_Object* pObj = it.second.get();

if (!pObj)

continue;

@@ -179,7 +179,7 @@ FX_BOOL FindFont(CPDF_Dictionary* pFormDict,

for (const auto& it : *pFonts) {

const CFX_ByteString& csKey = it.first;

- CPDF_Object* pObj = it.second;

+ CPDF_Object* pObj = it.second.get();

if (!pObj)

continue;

@@ -216,7 +216,7 @@ FX_BOOL FindFont(CPDF_Dictionary* pFormDict,

for (const auto& it : *pFonts) {

const CFX_ByteString& csKey = it.first;

- CPDF_Object* pObj = it.second;

+ CPDF_Object* pObj = it.second.get();

if (!pObj)

continue;

« no previous file with comments | « core/fpdfdoc/cpdf_formfield.cpp ('k') | fpdfsdk/formfiller/cba_fontmap.cpp » ('j') | no next file with comments »