Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2385283002: reflow comments in platform/{testing,text} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews, leviw+bidiwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in platform/{testing,text} Also restore a few tables in text to their pre-formatted form. They need up to 243 columns to look at, so they should probably be formatted differently eventually, but not today. BUG=563793 Committed: https://crrev.com/032a07551461da50acc287ab6cd6a8957ba2418e Cr-Commit-Position: refs/heads/master@{#422506}

Patch Set 1 #

Patch Set 2 : git #

Patch Set 3 : idunnolol #

Unified diffs Side-by-side diffs Delta from patch set Stats (+682 lines, -774 lines) Patch
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp View 5 chunks +22 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/URLTestHelpers.h View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/URLTestHelpers.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiCharacterRun.h View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiContext.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiContext.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 17 chunks +41 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolverTest.cpp View 4 chunks +27 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiTestHarness.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/Character.h View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/Character.cpp View 6 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/text/CharacterEmoji.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h View 4 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/text/Hyphenation.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LineEnding.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleICU.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMacTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleWin.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/QuotedPrintable.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIterator.h View 4 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIterator.cpp View 1 2 7 chunks +103 lines, -305 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 7 chunks +24 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.h View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextStream.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeRange.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeRange.cpp View 4 chunks +213 lines, -211 lines 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp View 1 2 8 chunks +47 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeUtilitiesTest.cpp View 1 2 1 chunk +26 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/text/WritingMode.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenatorAOSP.h View 1 chunk +21 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenatorAOSP.cpp View 5 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
4 years, 2 months ago (2016-10-03 18:48:09 UTC) #5
eae
LGTM
4 years, 2 months ago (2016-10-03 19:45:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385283002/40001
4 years, 2 months ago (2016-10-03 19:51:38 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 20:09:02 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:12:15 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/032a07551461da50acc287ab6cd6a8957ba2418e
Cr-Commit-Position: refs/heads/master@{#422506}

Powered by Google App Engine
This is Rietveld 408576698