Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2385273004: DevTools: fix text editor autocompletion (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix text editor autocompletion We should remove words from index if this is the last word only. BUG=none R=dgozman Committed: https://crrev.com/fe91a7d49ac93eb4c75ffce9474ff019ecbee0c0 Cr-Commit-Position: refs/heads/master@{#422941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/sources/autocomplete-general.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/autocomplete-general-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/TextDictionary.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
lushnikov
please, take a look!
4 years, 2 months ago (2016-10-04 17:47:59 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-04 18:40:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385273004/1
4 years, 2 months ago (2016-10-04 18:47:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 21:39:08 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:41:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe91a7d49ac93eb4c75ffce9474ff019ecbee0c0
Cr-Commit-Position: refs/heads/master@{#422941}

Powered by Google App Engine
This is Rietveld 408576698