Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2385223004: arc: Fix DefaultApps flakiness (Closed)

Created:
4 years, 2 months ago by khmel
Modified:
4 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix DefaultApps flakiness This stabilizes ChromeLauncherControllerArcDefaultAppsTest. DefaultApps when it gets executed in batch mode. TEST=Multiple runs of unit_tests showed no retries for this test. TEST= out/Debug/unit_tests --gtest_filter=*ChromeLauncherController*. BUG=651969 Committed: https://crrev.com/408ec0eb747b66fb0951e845c155c8ec2f20bb35 Cr-Commit-Position: refs/heads/master@{#422528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
khmel
Hi, PTAL
4 years, 2 months ago (2016-10-03 19:48:01 UTC) #2
oshima
lgtm
4 years, 2 months ago (2016-10-03 20:28:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385223004/1
4 years, 2 months ago (2016-10-03 20:32:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 21:06:34 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:08:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/408ec0eb747b66fb0951e845c155c8ec2f20bb35
Cr-Commit-Position: refs/heads/master@{#422528}

Powered by Google App Engine
This is Rietveld 408576698