Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385213003: Reflow comments in Source/modules/encryptedmedia (Closed)

Created:
4 years, 2 months ago by jrummell
Modified:
4 years, 2 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, haraken, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in Source/modules/encryptedmedia BUG=563793 Committed: https://crrev.com/f06ae6a557327aa7d10755d65ea7f02673431054 Cr-Commit-Position: refs/heads/master@{#422617}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jrummell
PTAL. Looks like the majority of comments in encryptedmedia/ kept to the 80 character limit.
4 years, 2 months ago (2016-10-03 20:51:42 UTC) #2
xhwang
lgtm % tiny nit https://codereview.chromium.org/2385213003/diff/1/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp File third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp (right): https://codereview.chromium.org/2385213003/diff/1/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp#newcode172 third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp:172: // From https://w3c.github.io/encrypted-media/#setServerCertificate: tiny nit: ...
4 years, 2 months ago (2016-10-03 20:56:22 UTC) #3
jrummell
Thanks for the quick review. https://codereview.chromium.org/2385213003/diff/1/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp File third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp (right): https://codereview.chromium.org/2385213003/diff/1/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp#newcode172 third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp:172: // From https://w3c.github.io/encrypted-media/#setServerCertificate: On ...
4 years, 2 months ago (2016-10-03 21:28:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385213003/20001
4 years, 2 months ago (2016-10-03 21:29:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 00:15:07 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:18:54 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f06ae6a557327aa7d10755d65ea7f02673431054
Cr-Commit-Position: refs/heads/master@{#422617}

Powered by Google App Engine
This is Rietveld 408576698