Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23852002: java2dart improvements and new analyzer_experimental snapshot. (Closed)

Created:
7 years, 3 months ago by scheglov
Modified:
7 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

java2dart improvements and new analyzer_experimental snapshot. 1. All enums extend Enum class. 2. Remove more unneeded parentheses. 3. Remove type arugments for types with all wildcards. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1693 lines, -1426 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 9 chunks +23 lines, -55 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/BeautifySemanticProcessor.java View 2 chunks +7 lines, -6 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ConstructorSemanticProcessor.java View 2 chunks +10 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 5 chunks +11 lines, -56 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 2 chunks +8 lines, -12 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/BeautifySemanticProcessorTest.java View 2 chunks +3 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 121 chunks +161 lines, -130 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 8 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 34 chunks +77 lines, -53 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 25 chunks +36 lines, -38 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 166 chunks +433 lines, -349 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 7 chunks +6 lines, -15 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/instrumentation.dart View 3 chunks +2 lines, -11 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 90 chunks +329 lines, -318 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 59 chunks +330 lines, -166 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 14 chunks +35 lines, -53 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 6 chunks +4 lines, -22 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/utilities_collection.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/utilities_dart.dart View 3 chunks +2 lines, -11 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 14 chunks +31 lines, -49 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 12 chunks +134 lines, -45 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/test_support.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 3 months ago (2013-09-01 22:19:11 UTC) #1
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-09-02 16:59:25 UTC) #2
scheglov
7 years, 3 months ago (2013-09-02 19:01:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698