third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp - Issue 2385193002: FrameSinkIds use to WindowIds in window server, Process ID/Route ID in renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

Issue 2385193002: FrameSinkIds use to WindowIds in window server, Process ID/Route ID in renderer (Closed)

Patch Set: Added missing serialization Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

diff --git a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

index 78bb25034c57165246a362f85590711492a9190a..38e0535a6e79ef1aada1d22bb1f2b93bad2cb9fb 100644

--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp

@@ -64,9 +64,9 @@ OffscreenCanvas* HTMLCanvasElementModule::transferControlToOffscreenInternal(

if (bridge) {

// If a bridge exists, it means canvas.createSurfaceLayer() has been called

// and its SurfaceId has been populated as well.

- // TODO(fsamuel): Plumb FrameSinkId into blink.

offscreenCanvas->setSurfaceId(

bridge->getSurfaceId().frame_sink_id().client_id(),

+ bridge->getSurfaceId().frame_sink_id().sink_id(),

bridge->getSurfaceId().local_id(), bridge->getSurfaceId().nonce());

}

return offscreenCanvas;