Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2385183002: Ignoring all results but chartjson on disabled benchmark run. (Closed)

Created:
4 years, 2 months ago by eyaich1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignoring all results but chartjson on disabled benchmark run. Currently we are writing out only chartjson results when a disabled test is run but we still check for json results. BUG=chromium:647714 Committed: https://crrev.com/89b1e1527284754aa13e7a9fc5e7731105bc4886 Cr-Commit-Position: refs/heads/master@{#422630}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M testing/scripts/run_telemetry_benchmark_as_googletest.py View 1 chunk +13 lines, -8 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
eyaich1
4 years, 2 months ago (2016-10-03 14:27:55 UTC) #2
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2385183002/diff/1/testing/scripts/run_telemetry_benchmark_as_googletest.py File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): https://codereview.chromium.org/2385183002/diff/1/testing/scripts/run_telemetry_benchmark_as_googletest.py#newcode74 testing/scripts/run_telemetry_benchmark_as_googletest.py:74: # If we have also output chartjson read ...
4 years, 2 months ago (2016-10-03 21:20:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385183002/1
4 years, 2 months ago (2016-10-03 23:03:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:34:39 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:36:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89b1e1527284754aa13e7a9fc5e7731105bc4886
Cr-Commit-Position: refs/heads/master@{#422630}

Powered by Google App Engine
This is Rietveld 408576698