Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2385163002: [tools/perf] Reenable qq mobile story (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
Reviewers:
perezju, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Reenable qq mobile story BUG=627166 Committed: https://crrev.com/7e9a61a40dbe068092704d6c9f9c2fe9a1d12e1d Cr-Commit-Position: refs/heads/master@{#422417}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 12 (6 generated)
nednguyen
4 years, 2 months ago (2016-10-03 13:35:54 UTC) #2
perezju
https://codereview.chromium.org/2385163002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py File tools/perf/page_sets/system_health/browsing_stories.py (left): https://codereview.chromium.org/2385163002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py#oldcode158 tools/perf/page_sets/system_health/browsing_stories.py:158: @decorators.Disabled('all') should it remain disabled on desktop?
4 years, 2 months ago (2016-10-03 13:36:49 UTC) #5
petrcermak
LGTM. Thanks, Petr https://codereview.chromium.org/2385163002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py File tools/perf/page_sets/system_health/browsing_stories.py (left): https://codereview.chromium.org/2385163002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py#oldcode158 tools/perf/page_sets/system_health/browsing_stories.py:158: @decorators.Disabled('all') On 2016/10/03 13:36:49, perezju wrote: ...
4 years, 2 months ago (2016-10-03 13:40:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385163002/1
4 years, 2 months ago (2016-10-03 13:42:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 14:30:22 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 14:32:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e9a61a40dbe068092704d6c9f9c2fe9a1d12e1d
Cr-Commit-Position: refs/heads/master@{#422417}

Powered by Google App Engine
This is Rietveld 408576698