Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2385143003: [android] Don't attempt to read a command on failure to start the forwarder. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
Reviewers:
Ted C, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Don't attempt to read a command on failure to start the forwarder. BUG=652250 Committed: https://crrev.com/bacf00e3bd031eaef1facd16335e355c722cd9fe Cr-Commit-Position: refs/heads/master@{#422449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tools/android/forwarder2/host_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/host_controller.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jbudorick
4 years, 2 months ago (2016-10-03 16:02:24 UTC) #2
jbudorick
+ted: as offered, a monday morning review :)
4 years, 2 months ago (2016-10-03 17:07:18 UTC) #8
Ted C
lgtm
4 years, 2 months ago (2016-10-03 17:16:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385143003/1
4 years, 2 months ago (2016-10-03 17:18:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 17:24:14 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 17:26:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bacf00e3bd031eaef1facd16335e355c722cd9fe
Cr-Commit-Position: refs/heads/master@{#422449}

Powered by Google App Engine
This is Rietveld 408576698