Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: pkg/barback/lib/src/transform_node.dart

Issue 238513002: Lazy transformers followed by non-lazy ones shouldn't always be forced. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/barback/test/package_graph/lazy_transformer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/transform_node.dart
diff --git a/pkg/barback/lib/src/transform_node.dart b/pkg/barback/lib/src/transform_node.dart
index 9e02e3656f72867ccc610f45a51d9b2421a38cd1..5eb0e6b5c36c687fd90be766fcc8ee535756f95f 100644
--- a/pkg/barback/lib/src/transform_node.dart
+++ b/pkg/barback/lib/src/transform_node.dart
@@ -139,8 +139,6 @@ class TransformNode {
_onLogPool.add(_onLogController.stream);
- if (!deferred) primary.force();
-
_primarySubscription = primary.onStateChange.listen((state) {
if (state.isRemoved) {
remove();
@@ -253,6 +251,7 @@ class TransformNode {
}).then((isPrimary) {
if (_isRemoved) return null;
if (isPrimary) {
+ if (!deferred) primary.force();
return _declareOutputs().then((_) {
if (_isRemoved) return;
if (_awaitingForce) {
« no previous file with comments | « no previous file | pkg/barback/test/package_graph/lazy_transformer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698