Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Issue 2385123005: Enable WebVR origin trial experiments. (Closed)
Patch Set: Update ConditionalFeaturesForModules.cpp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
index 6beb6f5ef2f77044b24f8ee353045dba167d0bc5..03975e2c503ab294ab26ce9b454ddce653221a31 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
@@ -75,6 +75,12 @@ void installConditionalFeaturesForModules(
V8NavigatorPartial::installWebUSB(isolate, world, v8::Local<v8::Object>(),
prototypeObject, interfaceObject);
}
+ if (RuntimeEnabledFeatures::webVREnabled() ||
+ (originTrialContext &&
+ originTrialContext->isFeatureEnabled("WebVR"))) {
+ V8WindowPartial::installWebVR(isolate, world, global, prototypeObject,
iclelland 2016/10/05 21:55:57 This should probably be V8NavigatorPartial::instal
amp 2016/10/05 22:04:43 Ah, yes it should. I wasn't paying enough attenti
+ interfaceObject);
+ }
} else if (wrapperTypeInfo == &V8WorkerNavigator::wrapperTypeInfo) {
if (RuntimeEnabledFeatures::durableStorageEnabled() ||
(originTrialContext &&
@@ -102,6 +108,12 @@ void installConditionalFeaturesForModules(
V8WindowPartial::installWebUSB(isolate, world, global, prototypeObject,
interfaceObject);
}
+ if (RuntimeEnabledFeatures::webVREnabled() ||
+ (originTrialContext &&
+ originTrialContext->isFeatureEnabled("WebVR"))) {
+ V8WindowPartial::installWebVR(isolate, world, global, prototypeObject,
+ interfaceObject);
+ }
} else if (wrapperTypeInfo == &V8SharedWorkerGlobalScope::wrapperTypeInfo) {
if (RuntimeEnabledFeatures::durableStorageEnabled() ||
(originTrialContext &&

Powered by Google App Engine
This is Rietveld 408576698