Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2385123005: Enable WebVR origin trial experiments. (Closed)
Patch Set: Update ConditionalFeaturesForModules.cpp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 759b8b3368f566ac400ab68d916c9c68f83c9eb4..5530e82ff19d97e22ff6f14744fdb51702fb5f59 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2184,7 +2184,16 @@ void RenderFrameHostImpl::RegisterMojoInterfaces() {
const base::CommandLine& browser_command_line =
*base::CommandLine::ForCurrentProcess();
+ // What to do here? This is behind a build flag any way so maybe wait until
iclelland 2016/10/05 21:55:57 If WebVR ships as an origin trial, then I think th
amp 2016/10/05 22:04:43 I think we are going for having the components alw
+ // that is fixed to modify this, but then should this be gated by runtime and
+ // origin trial features, not a command line switch directly?
+ // WebBluetooth (which is also in an origin trial) also uses a command line
+ // switch in this file.
if (browser_command_line.HasSwitch(switches::kEnableWebVR)) {
+ /*
+ if (RuntimeEnabledFeatures::webVREnabled())
+ // || OriginTrials::webVREnabled())
+ */
GetInterfaceRegistry()->AddInterface<device::VRService>(
base::Bind(&device::VRServiceImpl::BindRequest));
}

Powered by Google App Engine
This is Rietveld 408576698