Enable WebVR origin trial experiments.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 2183 matching lines @@
 
   // This is to support usage of WebSockets in cases in which there is an
   // associated RenderFrame. This is important for showing the correct security
   // state of the page and also honoring user override of bad certificates.
   GetInterfaceRegistry()->AddInterface(
       base::Bind(&WebSocketManager::CreateWebSocket,
                  process_->GetID(),
                  routing_id_));
 
 #if defined(ENABLE_WEBVR)
-  const base::CommandLine& browser_command_line =
-      *base::CommandLine::ForCurrentProcess();
-
-  if (browser_command_line.HasSwitch(switches::kEnableWebVR)) {

[clamy, 2016/10/07 11:09:54]

Why not use directly "if
(base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableWebVR))"?
This is what's done everywhere in the code.

[iclelland, 2016/10/07 14:51:50]

Isn't that line being deleted, though?

[clamy, 2016/10/07 14:54:40]

I'm not quite sure what you mean? If you like at
https://cs.chromium.org/chromium/src/content/common/site_isolation_policy.cc?...
for example, this is what we use. Note that the functions are used all over the
code, at various points in time.

[iclelland, 2016/10/07 15:11:16]

I mean that this CL *deletes* the line you're talking about.

base::CommandLine::ForCurrentProcess()->HasSwitch(...) is definitely the idiom
of choice, but it's no longer required once this feature is enabled as an origin
trial.

[clamy, 2016/10/07 15:13:59]

Sorry my bad, I read too quickly :-/.

-    GetInterfaceRegistry()->AddInterface<device::VRService>(
-        base::Bind(&device::VRServiceImpl::BindRequest));
-  }
+  GetInterfaceRegistry()->AddInterface<device::VRService>(
+      base::Bind(&device::VRServiceImpl::BindRequest));
 #endif
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableGenericSensors)) {
     GetInterfaceRegistry()->AddInterface(
         base::Bind(&device::SensorProviderImpl::Create),
         BrowserThread::GetTaskRunnerForThread(BrowserThread::IO));
   }
 
   GetContentClient()->browser()->RegisterRenderFrameMojoInterfaces(
       GetInterfaceRegistry(), this);
@@ skipping 893 matching lines @@
   web_bluetooth_service_->SetClientConnectionErrorHandler(base::Bind(
       &RenderFrameHostImpl::DeleteWebBluetoothService, base::Unretained(this)));
   return web_bluetooth_service_.get();
 }
 
 void RenderFrameHostImpl::DeleteWebBluetoothService() {
   web_bluetooth_service_.reset();
 }
 
 }  // namespace content